ACPI: battery: Remove redundant NULL initalizations

ij-intel · rafaeljw · commit 3745de7f2d00 · 2024-08-02T16:22:11.000+02:00
A local 'battery' variable is initialized to NULL on two occassions where it is unconditionally rewritten later. Remove the unnecessary initializations. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://patch.msgid.link/20240731095345.2878-1-ilpo.jarvinen@linux.intel.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
@@ -1207,7 +1207,7 @@ static int acpi_battery_update_retry(struct acpi_battery *battery)
 static int acpi_battery_add(struct acpi_device *device)
 {
 	int result = 0;
-	struct acpi_battery *battery = NULL;
+	struct acpi_battery *battery;
 
 	if (!device)
 		return -EINVAL;
@@ -1260,7 +1260,7 @@ static int acpi_battery_add(struct acpi_device *device)
 
 static void acpi_battery_remove(struct acpi_device *device)
 {
-	struct acpi_battery *battery = NULL;
+	struct acpi_battery *battery;
 
 	if (!device || !acpi_driver_data(device))
 		return;

Original file line number	Diff line number	Diff line change
`@@ -1207,7 +1207,7 @@ static int acpi_battery_update_retry(struct acpi_battery *battery)`
`1207`	`1207`	`static int acpi_battery_add(struct acpi_device *device)`
`1208`	`1208`	`{`
`1209`	`1209`	`int result = 0;`
`1210`		`- struct acpi_battery *battery = NULL;`
	`1210`	`+ struct acpi_battery *battery;`
`1211`	`1211`
`1212`	`1212`	`if (!device)`
`1213`	`1213`	`return -EINVAL;`
`@@ -1260,7 +1260,7 @@ static int acpi_battery_add(struct acpi_device *device)`
`1260`	`1260`
`1261`	`1261`	`static void acpi_battery_remove(struct acpi_device *device)`
`1262`	`1262`	`{`
`1263`		`- struct acpi_battery *battery = NULL;`
	`1263`	`+ struct acpi_battery *battery;`
`1264`	`1264`
`1265`	`1265`	`if (!device \|\| !acpi_driver_data(device))`
`1266`	`1266`	`return;`