Skip to content

Commit 3779416

Browse files
captain5050namhyung
authored andcommitted
perf vendor events intel: Fix broadwellde tma_info_system_dram_bw_use metric
Broadwell-de has a consumer core and server uncore. The uncore_arb PMU isn't present and the broadwellx style cbox PMU should be used instead. Fix the tma_info_system_dram_bw_use metric to use the server metric rather than client. The associated converter script fix is in: intel/perfmon#111 Fixes: 7d12430 ("perf vendor events intel: Update broadwell variant events/metrics") Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Cc: Caleb Biggers <caleb.biggers@intel.com> Cc: Perry Taylor <perry.taylor@intel.com> Link: https://lore.kernel.org/r/20230926031034.1201145-1-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
1 parent 56e144f commit 3779416

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@
652652
},
653653
{
654654
"BriefDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]",
655-
"MetricExpr": "64 * (arb@event\\=0x81\\,umask\\=0x1@ + arb@event\\=0x84\\,umask\\=0x1@) / 1e6 / duration_time / 1e3",
655+
"MetricExpr": "64 * (UNC_M_CAS_COUNT.RD + UNC_M_CAS_COUNT.WR) / 1e9 / duration_time",
656656
"MetricGroup": "HPC;Mem;MemoryBW;SoC;tma_issueBW",
657657
"MetricName": "tma_info_system_dram_bw_use",
658658
"PublicDescription": "Average external Memory Bandwidth Use for reads and writes [GB / sec]. Related metrics: tma_fb_full, tma_mem_bandwidth, tma_sq_full"

0 commit comments

Comments
 (0)