Skip to content

Commit 379af13

Browse files
ccpalexKAGA-KOKO
authored andcommitted
docs: locking: Discourage from calling disable_irq() in atomic
Correct the example in the documentation so that disable_irq() is not being called in atomic context. disable_irq() calls sleeping synchronize_irq(), it's not allowed to call them in atomic context. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Manfred Spraul <manfred@colorfullife.com> Cc: linux-doc@vger.kernel.org Link: https://lore.kernel.org/lkml/87k02wbs2n.ffs@tglx/ Link: https://lore.kernel.org/r/20221212163715.830315-1-alexander.sverdlin@siemens.com
1 parent 17549b0 commit 379af13

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

Documentation/kernel-hacking/locking.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1277,11 +1277,11 @@ Manfred Spraul points out that you can still do this, even if the data
12771277
is very occasionally accessed in user context or softirqs/tasklets. The
12781278
irq handler doesn't use a lock, and all other accesses are done as so::
12791279

1280-
spin_lock(&lock);
1280+
mutex_lock(&lock);
12811281
disable_irq(irq);
12821282
...
12831283
enable_irq(irq);
1284-
spin_unlock(&lock);
1284+
mutex_unlock(&lock);
12851285

12861286
The disable_irq() prevents the irq handler from running
12871287
(and waits for it to finish if it's currently running on other CPUs).

Documentation/translations/it_IT/kernel-hacking/locking.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,11 +1307,11 @@ se i dati vengono occasionalmente utilizzati da un contesto utente o
13071307
da un'interruzione software. Il gestore d'interruzione non utilizza alcun
13081308
*lock*, e tutti gli altri accessi verranno fatti così::
13091309

1310-
spin_lock(&lock);
1310+
mutex_lock(&lock);
13111311
disable_irq(irq);
13121312
...
13131313
enable_irq(irq);
1314-
spin_unlock(&lock);
1314+
mutex_unlock(&lock);
13151315

13161316
La funzione disable_irq() impedisce al gestore d'interruzioni
13171317
d'essere eseguito (e aspetta che finisca nel caso fosse in esecuzione su

0 commit comments

Comments
 (0)