net: ethernet: ti: am65-cpsw: Fix error code in am65_cpsw_nuss_init_tx_chns()

Dan Carpenter · davem330 · commit 37d4f5556798 · 2023-10-04T10:29:55.000+01:00
This accidentally returns success, but it should return a negative error code. Fixes: 93a7653 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Roger Quadros <rogerq@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1750,6 +1750,7 @@ static int am65_cpsw_nuss_init_tx_chns(struct am65_cpsw_common *common)
 		if (tx_chn->irq <= 0) {
 			dev_err(dev, "Failed to get tx dma irq %d\n",
 				tx_chn->irq);
+			ret = tx_chn->irq ?: -ENXIO;
 			goto err;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1750,6 +1750,7 @@ static int am65_cpsw_nuss_init_tx_chns(struct am65_cpsw_common *common)`
`1750`	`1750`	`if (tx_chn->irq <= 0) {`
`1751`	`1751`	`dev_err(dev, "Failed to get tx dma irq %d\n",`
`1752`	`1752`	`tx_chn->irq);`
	`1753`	`+ ret = tx_chn->irq ?: -ENXIO;`
`1753`	`1754`	`goto err;`
`1754`	`1755`	`}`
`1755`	`1756`