Skip to content

Commit 3818708

Browse files
Kenneth Fengalexdeucher
authored andcommitted
drm/amd/pm: fix the high voltage issue after unload
fix the high voltage issue after unload on smu 13.0.10 Signed-off-by: Kenneth Feng <kenneth.feng@amd.com> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent ecedd99 commit 3818708

4 files changed

Lines changed: 48 additions & 14 deletions

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4135,18 +4135,22 @@ int amdgpu_device_init(struct amdgpu_device *adev,
41354135
adev->ip_blocks[i].status.hw = true;
41364136
}
41374137
}
4138+
} else if (amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 10) &&
4139+
!amdgpu_device_has_display_hardware(adev)) {
4140+
r = psp_gpu_reset(adev);
41384141
} else {
4139-
tmp = amdgpu_reset_method;
4140-
/* It should do a default reset when loading or reloading the driver,
4141-
* regardless of the module parameter reset_method.
4142-
*/
4143-
amdgpu_reset_method = AMD_RESET_METHOD_NONE;
4144-
r = amdgpu_asic_reset(adev);
4145-
amdgpu_reset_method = tmp;
4146-
if (r) {
4147-
dev_err(adev->dev, "asic reset on init failed\n");
4148-
goto failed;
4149-
}
4142+
tmp = amdgpu_reset_method;
4143+
/* It should do a default reset when loading or reloading the driver,
4144+
* regardless of the module parameter reset_method.
4145+
*/
4146+
amdgpu_reset_method = AMD_RESET_METHOD_NONE;
4147+
r = amdgpu_asic_reset(adev);
4148+
amdgpu_reset_method = tmp;
4149+
}
4150+
4151+
if (r) {
4152+
dev_err(adev->dev, "asic reset on init failed\n");
4153+
goto failed;
41504154
}
41514155
}
41524156

drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ static int smu_early_init(void *handle)
735735
smu->adev = adev;
736736
smu->pm_enabled = !!amdgpu_dpm;
737737
smu->is_apu = false;
738-
smu->smu_baco.state = SMU_BACO_STATE_EXIT;
738+
smu->smu_baco.state = SMU_BACO_STATE_NONE;
739739
smu->smu_baco.platform_support = false;
740740
smu->user_dpm_profile.fan_mode = -1;
741741

@@ -1966,10 +1966,25 @@ static int smu_smc_hw_cleanup(struct smu_context *smu)
19661966
return 0;
19671967
}
19681968

1969+
static int smu_reset_mp1_state(struct smu_context *smu)
1970+
{
1971+
struct amdgpu_device *adev = smu->adev;
1972+
int ret = 0;
1973+
1974+
if ((!adev->in_runpm) && (!adev->in_suspend) &&
1975+
(!amdgpu_in_reset(adev)) && amdgpu_ip_version(adev, MP1_HWIP, 0) ==
1976+
IP_VERSION(13, 0, 10) &&
1977+
!amdgpu_device_has_display_hardware(adev))
1978+
ret = smu_set_mp1_state(smu, PP_MP1_STATE_UNLOAD);
1979+
1980+
return ret;
1981+
}
1982+
19691983
static int smu_hw_fini(void *handle)
19701984
{
19711985
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
19721986
struct smu_context *smu = adev->powerplay.pp_handle;
1987+
int ret;
19731988

19741989
if (amdgpu_sriov_vf(adev) && !amdgpu_sriov_is_pp_one_vf(adev))
19751990
return 0;
@@ -1987,7 +2002,15 @@ static int smu_hw_fini(void *handle)
19872002

19882003
adev->pm.dpm_enabled = false;
19892004

1990-
return smu_smc_hw_cleanup(smu);
2005+
ret = smu_smc_hw_cleanup(smu);
2006+
if (ret)
2007+
return ret;
2008+
2009+
ret = smu_reset_mp1_state(smu);
2010+
if (ret)
2011+
return ret;
2012+
2013+
return 0;
19912014
}
19922015

19932016
static void smu_late_fini(void *handle)

drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ enum smu_reset_mode {
424424
enum smu_baco_state {
425425
SMU_BACO_STATE_ENTER = 0,
426426
SMU_BACO_STATE_EXIT,
427+
SMU_BACO_STATE_NONE,
427428
};
428429

429430
struct smu_baco_context {

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2751,7 +2751,13 @@ static int smu_v13_0_0_set_mp1_state(struct smu_context *smu,
27512751

27522752
switch (mp1_state) {
27532753
case PP_MP1_STATE_UNLOAD:
2754-
ret = smu_cmn_set_mp1_state(smu, mp1_state);
2754+
ret = smu_cmn_send_smc_msg_with_param(smu,
2755+
SMU_MSG_PrepareMp1ForUnload,
2756+
0x55, NULL);
2757+
2758+
if (!ret && smu->smu_baco.state == SMU_BACO_STATE_EXIT)
2759+
ret = smu_v13_0_disable_pmfw_state(smu);
2760+
27552761
break;
27562762
default:
27572763
/* Ignore others */

0 commit comments

Comments
 (0)