Skip to content

Commit 3836c73

Browse files
committed
gpio: sim: fix setting and getting multiple lines
We need to take mask into account in the set/get_multiple() callbacks. Use bitmap_replace() instead of bitmap_copy(). Fixes: cb8c474 ("gpio: sim: new testing module") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent ce522ba commit 3836c73

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpio/gpio-sim.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ static int gpio_sim_get_multiple(struct gpio_chip *gc,
134134
struct gpio_sim_chip *chip = gpiochip_get_data(gc);
135135

136136
mutex_lock(&chip->lock);
137-
bitmap_copy(bits, chip->value_map, gc->ngpio);
137+
bitmap_replace(bits, bits, chip->value_map, mask, gc->ngpio);
138138
mutex_unlock(&chip->lock);
139139

140140
return 0;
@@ -146,7 +146,7 @@ static void gpio_sim_set_multiple(struct gpio_chip *gc,
146146
struct gpio_sim_chip *chip = gpiochip_get_data(gc);
147147

148148
mutex_lock(&chip->lock);
149-
bitmap_copy(chip->value_map, bits, gc->ngpio);
149+
bitmap_replace(chip->value_map, chip->value_map, bits, mask, gc->ngpio);
150150
mutex_unlock(&chip->lock);
151151
}
152152

0 commit comments

Comments
 (0)