Skip to content

Commit 3858e8a

Browse files
Mani-Sadhasivamkwilczynski
authored andcommitted
PCI: qcom-ep: Drop the redundant masking of global IRQ events
Once the events are disabled in PARF_INT_ALL_MASK register, only the enabled events will generate global IRQ. So there is no need to do the masking again in the IRQ handler, drop it. If there are any spurious IRQs getting generated, they will be reported using the existing dev_err() in the handler. Link: https://lore.kernel.org/linux-pci/20240828-pci-qcom-hotplug-v4-1-263a385fbbcb@linaro.org Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
1 parent 8400291 commit 3858e8a

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -647,11 +647,9 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
647647
struct dw_pcie *pci = &pcie_ep->pci;
648648
struct device *dev = pci->dev;
649649
u32 status = readl_relaxed(pcie_ep->parf + PARF_INT_ALL_STATUS);
650-
u32 mask = readl_relaxed(pcie_ep->parf + PARF_INT_ALL_MASK);
651650
u32 dstate, val;
652651

653652
writel_relaxed(status, pcie_ep->parf + PARF_INT_ALL_CLEAR);
654-
status &= mask;
655653

656654
if (FIELD_GET(PARF_INT_ALL_LINK_DOWN, status)) {
657655
dev_dbg(dev, "Received Linkdown event\n");

0 commit comments

Comments
 (0)