Skip to content

Commit 38d9a4a

Browse files
atishp04avpatel
authored andcommitted
RISC-V: KVM: Restrict the extensions that can be disabled
Currently, the config isa register allows us to disable all allowed single letter ISA extensions. It shouldn't be the case as vmm shouldn't be able to disable base extensions (imac). These extensions should always be enabled as long as they are enabled in the host ISA. Signed-off-by: Atish Patra <atishp@rivosinc.com> Signed-off-by: Anup Patel <anup@brainfault.org> Fixes: 92ad820 ("RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls")
1 parent 3ab75a7 commit 38d9a4a

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

arch/riscv/kvm/vcpu.c

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,16 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
3838
sizeof(kvm_vcpu_stats_desc),
3939
};
4040

41-
#define KVM_RISCV_ISA_ALLOWED (riscv_isa_extension_mask(a) | \
42-
riscv_isa_extension_mask(c) | \
43-
riscv_isa_extension_mask(d) | \
44-
riscv_isa_extension_mask(f) | \
45-
riscv_isa_extension_mask(i) | \
46-
riscv_isa_extension_mask(m))
41+
#define KVM_RISCV_ISA_DISABLE_ALLOWED (riscv_isa_extension_mask(d) | \
42+
riscv_isa_extension_mask(f))
43+
44+
#define KVM_RISCV_ISA_DISABLE_NOT_ALLOWED (riscv_isa_extension_mask(a) | \
45+
riscv_isa_extension_mask(c) | \
46+
riscv_isa_extension_mask(i) | \
47+
riscv_isa_extension_mask(m))
48+
49+
#define KVM_RISCV_ISA_ALLOWED (KVM_RISCV_ISA_DISABLE_ALLOWED | \
50+
KVM_RISCV_ISA_DISABLE_NOT_ALLOWED)
4751

4852
static void kvm_riscv_reset_vcpu(struct kvm_vcpu *vcpu)
4953
{
@@ -217,7 +221,8 @@ static int kvm_riscv_vcpu_set_reg_config(struct kvm_vcpu *vcpu,
217221
switch (reg_num) {
218222
case KVM_REG_RISCV_CONFIG_REG(isa):
219223
if (!vcpu->arch.ran_atleast_once) {
220-
vcpu->arch.isa = reg_val;
224+
/* Ignore the disable request for these extensions */
225+
vcpu->arch.isa = reg_val | KVM_RISCV_ISA_DISABLE_NOT_ALLOWED;
221226
vcpu->arch.isa &= riscv_isa_extension_base(NULL);
222227
vcpu->arch.isa &= KVM_RISCV_ISA_ALLOWED;
223228
kvm_riscv_vcpu_fp_reset(vcpu);

0 commit comments

Comments
 (0)