drm/vmwgfx: fix typo of sizeof argument

BoardzMaster · zackr · commit 39465cac2837 · 2023-10-09T15:53:10.000-04:00
Since size of 'header' pointer and '*header' structure is equal on 64-bit machines issue probably didn't cause any wrong behavior. But anyway, fixing typo is required. Fixes: 7a73ba7 ("drm/vmwgfx: Use TTM handles instead of SIDs as user-space surface handles.") Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com> Reviewed-by: Zack Rusin <zackr@vmware.com> Signed-off-by: Zack Rusin <zackr@vmware.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230905100203.1716731-1-konstantin.meskhidze@huawei.com
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -1619,7 +1619,7 @@ static int vmw_cmd_tex_state(struct vmw_private *dev_priv,
 {
 	VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdSetTextureState);
 	SVGA3dTextureState *last_state = (SVGA3dTextureState *)
-	  ((unsigned long) header + header->size + sizeof(header));
+	  ((unsigned long) header + header->size + sizeof(*header));
 	SVGA3dTextureState *cur_state = (SVGA3dTextureState *)
 		((unsigned long) header + sizeof(*cmd));
 	struct vmw_resource *ctx;

Original file line number	Diff line number	Diff line change
`@@ -1619,7 +1619,7 @@ static int vmw_cmd_tex_state(struct vmw_private *dev_priv,`
`1619`	`1619`	`{`
`1620`	`1620`	`VMW_DECLARE_CMD_VAR(*cmd, SVGA3dCmdSetTextureState);`
`1621`	`1621`	`SVGA3dTextureState last_state = (SVGA3dTextureState )`
`1622`		`- ((unsigned long) header + header->size + sizeof(header));`
	`1622`	`+ ((unsigned long) header + header->size + sizeof(*header));`
`1623`	`1623`	`SVGA3dTextureState cur_state = (SVGA3dTextureState )`
`1624`	`1624`	`((unsigned long) header + sizeof(*cmd));`
`1625`	`1625`	`struct vmw_resource *ctx;`