Skip to content

Commit 3988a57

Browse files
committed
NFSD: Rename boot verifier functions
Clean up: These functions handle what the specs call a write verifier, which in the Linux NFS server implementation is now divorced from the server's boot instance Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 91d2e9b commit 3988a57

5 files changed

Lines changed: 20 additions & 20 deletions

File tree

fs/nfsd/filecache.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ nfsd_file_do_unhash(struct nfsd_file *nf)
243243
trace_nfsd_file_unhash(nf);
244244

245245
if (nfsd_file_check_write_error(nf))
246-
nfsd_reset_boot_verifier(net_generic(nf->nf_net, nfsd_net_id));
246+
nfsd_reset_write_verifier(net_generic(nf->nf_net, nfsd_net_id));
247247
--nfsd_file_hashtbl[nf->nf_hashval].nfb_count;
248248
hlist_del_rcu(&nf->nf_node);
249249
atomic_long_dec(&nfsd_filecache_count);

fs/nfsd/netns.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,6 @@ extern void nfsd_netns_free_versions(struct nfsd_net *nn);
198198

199199
extern unsigned int nfsd_net_id;
200200

201-
void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn);
202-
void nfsd_reset_boot_verifier(struct nfsd_net *nn);
201+
void nfsd_copy_write_verifier(__be32 verf[2], struct nfsd_net *nn);
202+
void nfsd_reset_write_verifier(struct nfsd_net *nn);
203203
#endif /* __NFSD_NETNS_H__ */

fs/nfsd/nfs4proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ static void gen_boot_verifier(nfs4_verifier *verifier, struct net *net)
598598

599599
BUILD_BUG_ON(2*sizeof(*verf) != sizeof(verifier->data));
600600

601-
nfsd_copy_boot_verifier(verf, net_generic(net, nfsd_net_id));
601+
nfsd_copy_write_verifier(verf, net_generic(net, nfsd_net_id));
602602
}
603603

604604
static __be32

fs/nfsd/nfssvc.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -346,14 +346,14 @@ static bool nfsd_needs_lockd(struct nfsd_net *nn)
346346
}
347347

348348
/**
349-
* nfsd_copy_boot_verifier - Atomically copy a write verifier
349+
* nfsd_copy_write_verifier - Atomically copy a write verifier
350350
* @verf: buffer in which to receive the verifier cookie
351351
* @nn: NFS net namespace
352352
*
353353
* This function provides a wait-free mechanism for copying the
354-
* namespace's boot verifier without tearing it.
354+
* namespace's write verifier without tearing it.
355355
*/
356-
void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
356+
void nfsd_copy_write_verifier(__be32 verf[2], struct nfsd_net *nn)
357357
{
358358
int seq = 0;
359359

@@ -364,7 +364,7 @@ void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
364364
done_seqretry(&nn->writeverf_lock, seq);
365365
}
366366

367-
static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
367+
static void nfsd_reset_write_verifier_locked(struct nfsd_net *nn)
368368
{
369369
struct timespec64 now;
370370
u64 verf;
@@ -379,7 +379,7 @@ static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
379379
}
380380

381381
/**
382-
* nfsd_reset_boot_verifier - Generate a new boot verifier
382+
* nfsd_reset_write_verifier - Generate a new write verifier
383383
* @nn: NFS net namespace
384384
*
385385
* This function updates the ->writeverf field of @nn. This field
@@ -391,10 +391,10 @@ static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
391391
* server and MUST be unique between instances of the NFSv4.1
392392
* server."
393393
*/
394-
void nfsd_reset_boot_verifier(struct nfsd_net *nn)
394+
void nfsd_reset_write_verifier(struct nfsd_net *nn)
395395
{
396396
write_seqlock(&nn->writeverf_lock);
397-
nfsd_reset_boot_verifier_locked(nn);
397+
nfsd_reset_write_verifier_locked(nn);
398398
write_sequnlock(&nn->writeverf_lock);
399399
}
400400

@@ -683,7 +683,7 @@ int nfsd_create_serv(struct net *net)
683683
register_inet6addr_notifier(&nfsd_inet6addr_notifier);
684684
#endif
685685
}
686-
nfsd_reset_boot_verifier(nn);
686+
nfsd_reset_write_verifier(nn);
687687
return 0;
688688
}
689689

fs/nfsd/vfs.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -559,8 +559,8 @@ __be32 nfsd4_clone_file_range(struct svc_rqst *rqstp,
559559
&nfsd4_get_cstate(rqstp)->current_fh,
560560
dst_pos,
561561
count, status);
562-
nfsd_reset_boot_verifier(net_generic(nf_dst->nf_net,
563-
nfsd_net_id));
562+
nfsd_reset_write_verifier(net_generic(nf_dst->nf_net,
563+
nfsd_net_id));
564564
ret = nfserrno(status);
565565
}
566566
}
@@ -1013,10 +1013,10 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
10131013
iov_iter_kvec(&iter, WRITE, vec, vlen, *cnt);
10141014
since = READ_ONCE(file->f_wb_err);
10151015
if (verf)
1016-
nfsd_copy_boot_verifier(verf, nn);
1016+
nfsd_copy_write_verifier(verf, nn);
10171017
host_err = vfs_iter_write(file, &iter, &pos, flags);
10181018
if (host_err < 0) {
1019-
nfsd_reset_boot_verifier(nn);
1019+
nfsd_reset_write_verifier(nn);
10201020
goto out_nfserr;
10211021
}
10221022
*cnt = host_err;
@@ -1029,7 +1029,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
10291029
if (stable && use_wgather) {
10301030
host_err = wait_for_concurrent_writes(file);
10311031
if (host_err < 0)
1032-
nfsd_reset_boot_verifier(nn);
1032+
nfsd_reset_write_verifier(nn);
10331033
}
10341034

10351035
out_nfserr:
@@ -1142,19 +1142,19 @@ nfsd_commit(struct svc_rqst *rqstp, struct svc_fh *fhp,
11421142
err2 = vfs_fsync_range(nf->nf_file, offset, end, 0);
11431143
switch (err2) {
11441144
case 0:
1145-
nfsd_copy_boot_verifier(verf, nn);
1145+
nfsd_copy_write_verifier(verf, nn);
11461146
err2 = filemap_check_wb_err(nf->nf_file->f_mapping,
11471147
since);
11481148
break;
11491149
case -EINVAL:
11501150
err = nfserr_notsupp;
11511151
break;
11521152
default:
1153-
nfsd_reset_boot_verifier(nn);
1153+
nfsd_reset_write_verifier(nn);
11541154
}
11551155
err = nfserrno(err2);
11561156
} else
1157-
nfsd_copy_boot_verifier(verf, nn);
1157+
nfsd_copy_write_verifier(verf, nn);
11581158

11591159
nfsd_file_put(nf);
11601160
out:

0 commit comments

Comments
 (0)