Skip to content

Commit 39b930b

Browse files
akhilr-nvvinodkoul
authored andcommitted
dmaengine: tegra: Fix uninitialized variable usage
Initialize slave_bw in dma_prep*() functions as the parameter is not set for DMA_MEM_TO_MEM case in get_transfer_param(). Though the case may never occur, initializing it avoids warning from certain static checkers Fixes: ee17028 ("dmaengine: tegra: Add tegra gpcdma driver") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Akhil R <akhilrajeev@nvidia.com> Link: https://lore.kernel.org/r/20220426101913.43335-2-akhilrajeev@nvidia.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 099a9a9 commit 39b930b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/dma/tegra186-gpc-dma.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -984,8 +984,8 @@ tegra_dma_prep_slave_sg(struct dma_chan *dc, struct scatterlist *sgl,
984984
{
985985
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
986986
unsigned int max_dma_count = tdc->tdma->chip_data->max_dma_count;
987+
enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
987988
u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0;
988-
enum dma_slave_buswidth slave_bw;
989989
struct tegra_dma_sg_req *sg_req;
990990
struct tegra_dma_desc *dma_desc;
991991
struct scatterlist *sg;
@@ -1102,12 +1102,12 @@ tegra_dma_prep_dma_cyclic(struct dma_chan *dc, dma_addr_t buf_addr, size_t buf_l
11021102
size_t period_len, enum dma_transfer_direction direction,
11031103
unsigned long flags)
11041104
{
1105+
enum dma_slave_buswidth slave_bw = DMA_SLAVE_BUSWIDTH_UNDEFINED;
1106+
u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
1107+
unsigned int max_dma_count, len, period_count, i;
11051108
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
11061109
struct tegra_dma_desc *dma_desc;
11071110
struct tegra_dma_sg_req *sg_req;
1108-
enum dma_slave_buswidth slave_bw;
1109-
u32 csr, mc_seq, apb_ptr = 0, mmio_seq = 0, burst_size;
1110-
unsigned int max_dma_count, len, period_count, i;
11111111
dma_addr_t mem = buf_addr;
11121112
int ret;
11131113

0 commit comments

Comments
 (0)