Skip to content

Commit 39c1f1b

Browse files
roygerandy-shev
authored andcommitted
pinctrl: intel: check REVID register value for device presence
Use the value read from the REVID register in order to check for the presence of the device. A read of all ones is treated as if the device is not present, and hence probing is ended. This fixes an issue when running as a Xen PVH dom0, where the ACPI DSDT table is provided unmodified to dom0 and hence contains the pinctrl devices, but the MMIO region(s) containing the device registers might not be mapped in the guest physical memory map if such region(s) are not exposed on a PCI device BAR or marked as reserved in the host memory map. Fixes: 91d898e ("pinctrl: intel: Convert capability list to features") Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent 77e1412 commit 39c1f1b

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/pinctrl/intel/pinctrl-intel.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1493,8 +1493,13 @@ static int intel_pinctrl_probe(struct platform_device *pdev,
14931493
if (IS_ERR(regs))
14941494
return PTR_ERR(regs);
14951495

1496-
/* Determine community features based on the revision */
1496+
/*
1497+
* Determine community features based on the revision.
1498+
* A value of all ones means the device is not present.
1499+
*/
14971500
value = readl(regs + REVID);
1501+
if (value == ~0u)
1502+
return -ENODEV;
14981503
if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) {
14991504
community->features |= PINCTRL_FEATURE_DEBOUNCE;
15001505
community->features |= PINCTRL_FEATURE_1K_PD;

0 commit comments

Comments
 (0)