Skip to content

Commit 39e0b96

Browse files
bijudasdianders
authored andcommitted
drm/bridge/analogix/anx78xx: Drop ID table
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230831080938.47454-2-biju.das.jz@bp.renesas.com
1 parent 6bd3d8d commit 39e0b96

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client)
13671367
kfree(anx78xx->edid);
13681368
}
13691369

1370-
static const struct i2c_device_id anx78xx_id[] = {
1371-
{ "anx7814", 0 },
1372-
{ /* sentinel */ }
1373-
};
1374-
MODULE_DEVICE_TABLE(i2c, anx78xx_id);
1375-
13761370
static const struct of_device_id anx78xx_match_table[] = {
13771371
{ .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses },
13781372
{ .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses },
@@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = {
13891383
},
13901384
.probe = anx78xx_i2c_probe,
13911385
.remove = anx78xx_i2c_remove,
1392-
.id_table = anx78xx_id,
13931386
};
13941387
module_i2c_driver(anx78xx_driver);
13951388

0 commit comments

Comments
 (0)