Skip to content

Commit 3a373e0

Browse files
committed
KVM: fix direction of dependency on MMU notifiers
KVM_GENERIC_MEMORY_ATTRIBUTES requires the generic MMU notifier code, because it uses kvm_mmu_invalidate_begin/end. However, it would not work with a bespoke implementation of MMU notifiers that does not use KVM_GENERIC_MMU_NOTIFIER, because most likely it would not synchronize correctly on invalidation. So the right thing to do is to note the problematic configuration if the architecture does not select itself KVM_GENERIC_MMU_NOTIFIER; not to enable it blindly. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent caadf87 commit 3a373e0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

virt/kvm/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ config KVM_GENERIC_MMU_NOTIFIER
9797
bool
9898

9999
config KVM_GENERIC_MEMORY_ATTRIBUTES
100-
select KVM_GENERIC_MMU_NOTIFIER
100+
depends on KVM_GENERIC_MMU_NOTIFIER
101101
bool
102102

103103
config KVM_PRIVATE_MEM

0 commit comments

Comments
 (0)