Skip to content

Commit 3af4ec7

Browse files
Uwe Kleine-Könignmenon
authored andcommitted
soc/ti: knav_dma: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> # qcom Link: https://lore.kernel.org/r/20230925095532.1984344-35-u.kleine-koenig@pengutronix.de Signed-off-by: Nishanth Menon <nm@ti.com>
1 parent f34b902 commit 3af4ec7

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/soc/ti/knav_dma.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,7 @@ static int knav_dma_probe(struct platform_device *pdev)
773773
return ret;
774774
}
775775

776-
static int knav_dma_remove(struct platform_device *pdev)
776+
static void knav_dma_remove(struct platform_device *pdev)
777777
{
778778
struct knav_dma_device *dma;
779779

@@ -784,8 +784,6 @@ static int knav_dma_remove(struct platform_device *pdev)
784784

785785
pm_runtime_put_sync(&pdev->dev);
786786
pm_runtime_disable(&pdev->dev);
787-
788-
return 0;
789787
}
790788

791789
static struct of_device_id of_match[] = {
@@ -797,7 +795,7 @@ MODULE_DEVICE_TABLE(of, of_match);
797795

798796
static struct platform_driver knav_dma_driver = {
799797
.probe = knav_dma_probe,
800-
.remove = knav_dma_remove,
798+
.remove_new = knav_dma_remove,
801799
.driver = {
802800
.name = "keystone-navigator-dma",
803801
.of_match_table = of_match,

0 commit comments

Comments
 (0)