Skip to content

Commit 3b2562d

Browse files
committed
drm/i915/gt: skip WA verification for GEN7_MISCCPCTL on DG2
Some DG2 firmware locks this register for modification. Using wa_add with read_mask 0 allows to skip checks of such registers. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8945 Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230912073521.2106162-1-andrzej.hajda@intel.com
1 parent c795d2f commit 3b2562d

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1596,8 +1596,12 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
15961596
/* Wa_14014830051:dg2 */
15971597
wa_mcr_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
15981598

1599-
/* Wa_14015795083 */
1600-
wa_write_clr(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE);
1599+
/*
1600+
* Wa_14015795083
1601+
* Skip verification for possibly locked register.
1602+
*/
1603+
wa_add(wal, GEN7_MISCCPCTL, GEN12_DOP_CLOCK_GATE_RENDER_ENABLE,
1604+
0, 0, false);
16011605

16021606
/* Wa_18018781329 */
16031607
wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);

0 commit comments

Comments
 (0)