Skip to content

Commit 3b74801

Browse files
konradybcioandersson
authored andcommitted
interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req
Currently, we're setting the aggregated-on-provider bandwidth on each node, individually. That is of course incorrect and results in far too high votes. Use the correct values to ensure we're not wasting power. Fixes: 30c8fa3 ("interconnect: qcom: Add MSM8916 interconnect provider driver") Reported-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Stephan Gerhold <stephan@gerhold.net> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Acked-by: Georgi Djakov <djakov@kernel.org> Link: https://lore.kernel.org/r/20230526-topic-smd_icc-v7-21-09c78c175546@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 32846c4 commit 3b74801

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/interconnect/qcom/icc-rpm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,12 +354,12 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
354354

355355
qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg);
356356

357-
ret = qcom_icc_rpm_set(src_qn, agg_avg);
357+
ret = qcom_icc_rpm_set(src_qn, src_qn->sum_avg);
358358
if (ret)
359359
return ret;
360360

361361
if (dst_qn) {
362-
ret = qcom_icc_rpm_set(dst_qn, agg_avg);
362+
ret = qcom_icc_rpm_set(dst_qn, dst_qn->sum_avg);
363363
if (ret)
364364
return ret;
365365
}

0 commit comments

Comments
 (0)