Skip to content

Commit 3b76b73

Browse files
Mani-Sadhasivamandersson
authored andcommitted
ARM: dts: qcom: sdx55: Fix the unit address of PCIe EP node
Unit address of PCIe EP node should be 0x1c00000 as it has to match the first address specified in the reg property. This also requires sorting the node in the ascending order. Fixes: e6b6981 ("ARM: dts: qcom: sdx55: Add support for PCIe EP") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20230308082424.140224-6-manivannan.sadhasivam@linaro.org
1 parent 0b16b34 commit 3b76b73

1 file changed

Lines changed: 39 additions & 39 deletions

File tree

arch/arm/boot/dts/qcom-sdx55.dtsi

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,45 @@
304304
status = "disabled";
305305
};
306306

307+
pcie_ep: pcie-ep@1c00000 {
308+
compatible = "qcom,sdx55-pcie-ep";
309+
reg = <0x01c00000 0x3000>,
310+
<0x40000000 0xf1d>,
311+
<0x40000f20 0xc8>,
312+
<0x40001000 0x1000>,
313+
<0x40200000 0x100000>,
314+
<0x01c03000 0x3000>;
315+
reg-names = "parf", "dbi", "elbi", "atu", "addr_space",
316+
"mmio";
317+
318+
qcom,perst-regs = <&tcsr 0xb258 0xb270>;
319+
320+
clocks = <&gcc GCC_PCIE_AUX_CLK>,
321+
<&gcc GCC_PCIE_CFG_AHB_CLK>,
322+
<&gcc GCC_PCIE_MSTR_AXI_CLK>,
323+
<&gcc GCC_PCIE_SLV_AXI_CLK>,
324+
<&gcc GCC_PCIE_SLV_Q2A_AXI_CLK>,
325+
<&gcc GCC_PCIE_SLEEP_CLK>,
326+
<&gcc GCC_PCIE_0_CLKREF_CLK>;
327+
clock-names = "aux", "cfg", "bus_master", "bus_slave",
328+
"slave_q2a", "sleep", "ref";
329+
330+
interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>,
331+
<GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>;
332+
interrupt-names = "global", "doorbell";
333+
reset-gpios = <&tlmm 57 GPIO_ACTIVE_LOW>;
334+
wake-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
335+
resets = <&gcc GCC_PCIE_BCR>;
336+
reset-names = "core";
337+
power-domains = <&gcc PCIE_GDSC>;
338+
phys = <&pcie0_lane>;
339+
phy-names = "pciephy";
340+
max-link-speed = <3>;
341+
num-lanes = <2>;
342+
343+
status = "disabled";
344+
};
345+
307346
pcie0_phy: phy@1c07000 {
308347
compatible = "qcom,sdx55-qmp-pcie-phy";
309348
reg = <0x01c07000 0x1c4>;
@@ -401,45 +440,6 @@
401440
status = "disabled";
402441
};
403442

404-
pcie_ep: pcie-ep@40000000 {
405-
compatible = "qcom,sdx55-pcie-ep";
406-
reg = <0x01c00000 0x3000>,
407-
<0x40000000 0xf1d>,
408-
<0x40000f20 0xc8>,
409-
<0x40001000 0x1000>,
410-
<0x40200000 0x100000>,
411-
<0x01c03000 0x3000>;
412-
reg-names = "parf", "dbi", "elbi", "atu", "addr_space",
413-
"mmio";
414-
415-
qcom,perst-regs = <&tcsr 0xb258 0xb270>;
416-
417-
clocks = <&gcc GCC_PCIE_AUX_CLK>,
418-
<&gcc GCC_PCIE_CFG_AHB_CLK>,
419-
<&gcc GCC_PCIE_MSTR_AXI_CLK>,
420-
<&gcc GCC_PCIE_SLV_AXI_CLK>,
421-
<&gcc GCC_PCIE_SLV_Q2A_AXI_CLK>,
422-
<&gcc GCC_PCIE_SLEEP_CLK>,
423-
<&gcc GCC_PCIE_0_CLKREF_CLK>;
424-
clock-names = "aux", "cfg", "bus_master", "bus_slave",
425-
"slave_q2a", "sleep", "ref";
426-
427-
interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>,
428-
<GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>;
429-
interrupt-names = "global", "doorbell";
430-
reset-gpios = <&tlmm 57 GPIO_ACTIVE_LOW>;
431-
wake-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
432-
resets = <&gcc GCC_PCIE_BCR>;
433-
reset-names = "core";
434-
power-domains = <&gcc PCIE_GDSC>;
435-
phys = <&pcie0_lane>;
436-
phy-names = "pciephy";
437-
max-link-speed = <3>;
438-
num-lanes = <2>;
439-
440-
status = "disabled";
441-
};
442-
443443
remoteproc_mpss: remoteproc@4080000 {
444444
compatible = "qcom,sdx55-mpss-pas";
445445
reg = <0x04080000 0x4040>;

0 commit comments

Comments
 (0)