Skip to content

Commit 3b87e60

Browse files
vladimirolteankuba-moo
authored andcommitted
net: dsa: mt7530: unexport mt7530_switch_ops
Commit cb675af ("net: dsa: mt7530: introduce separate MDIO driver") exported mt7530_switch_ops for use from mt7530-mmio.c. Later in the patch set, mt7530-mmio.c used mt7530_probe_common() to access the mt7530_switch_ops still from mt7530.c - see commit 110c18b ("net: dsa: mt7530: introduce driver for MT7988 built-in switch"). This proves that exporting mt7530_switch_ops was unnecessary, so unexport it back. Cc: DENG Qingfang <dqfext@gmail.com> Cc: Sean Wang <sean.wang@mediatek.com> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Daniel Golle <daniel@makrotopia.org> Acked-by: Chester A. Unal <chester.a.unal@arinc9.com> Link: https://patch.msgid.link/20251130131657.65080-2-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b4dcaee commit 3b87e60

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/net/dsa/mt7530.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3254,7 +3254,7 @@ static int mt7988_setup(struct dsa_switch *ds)
32543254
return mt7531_setup_common(ds);
32553255
}
32563256

3257-
const struct dsa_switch_ops mt7530_switch_ops = {
3257+
static const struct dsa_switch_ops mt7530_switch_ops = {
32583258
.get_tag_protocol = mtk_get_tag_protocol,
32593259
.setup = mt753x_setup,
32603260
.preferred_default_local_cpu_port = mt753x_preferred_default_local_cpu_port,
@@ -3291,7 +3291,6 @@ const struct dsa_switch_ops mt7530_switch_ops = {
32913291
.conduit_state_change = mt753x_conduit_state_change,
32923292
.port_setup_tc = mt753x_setup_tc,
32933293
};
3294-
EXPORT_SYMBOL_GPL(mt7530_switch_ops);
32953294

32963295
static const struct phylink_mac_ops mt753x_phylink_mac_ops = {
32973296
.mac_select_pcs = mt753x_phylink_mac_select_pcs,

drivers/net/dsa/mt7530.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,6 @@ static inline void INIT_MT7530_DUMMY_POLL(struct mt7530_dummy_poll *p,
939939
int mt7530_probe_common(struct mt7530_priv *priv);
940940
void mt7530_remove_common(struct mt7530_priv *priv);
941941

942-
extern const struct dsa_switch_ops mt7530_switch_ops;
943942
extern const struct mt753x_info mt753x_table[];
944943

945944
#endif /* __MT7530_H */

0 commit comments

Comments
 (0)