scsi: lpfc: Remove redundant NULL ptr assignment in lpfc_els_free_iocb()

Justin Tee · martinkpetersen · commit 3c228061c80d · 2025-11-08T13:18:00.000-05:00
Remove redundant cmd_dmabuf and bpl_dmabuf NULL ptr assignment as they are already initialized to NULL when handling a new unsolicited event. Signed-off-by: Justin Tee <justin.tee@broadcom.com> Link: https://patch.msgid.link/20251106224639.139176-4-justintee8345@gmail.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
@@ -5159,14 +5159,12 @@ lpfc_els_free_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *elsiocb)
 		} else {
 			buf_ptr1 = elsiocb->cmd_dmabuf;
 			lpfc_els_free_data(phba, buf_ptr1);
-			elsiocb->cmd_dmabuf = NULL;
 		}
 	}
 
 	if (elsiocb->bpl_dmabuf) {
 		buf_ptr = elsiocb->bpl_dmabuf;
 		lpfc_els_free_bpl(phba, buf_ptr);
-		elsiocb->bpl_dmabuf = NULL;
 	}
 	lpfc_sli_release_iocbq(phba, elsiocb);
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -5159,14 +5159,12 @@ lpfc_els_free_iocb(struct lpfc_hba phba, struct lpfc_iocbq elsiocb)`
`5159`	`5159`	`} else {`
`5160`	`5160`	`buf_ptr1 = elsiocb->cmd_dmabuf;`
`5161`	`5161`	`lpfc_els_free_data(phba, buf_ptr1);`
`5162`		`- elsiocb->cmd_dmabuf = NULL;`
`5163`	`5162`	`}`
`5164`	`5163`	`}`
`5165`	`5164`
`5166`	`5165`	`if (elsiocb->bpl_dmabuf) {`
`5167`	`5166`	`buf_ptr = elsiocb->bpl_dmabuf;`
`5168`	`5167`	`lpfc_els_free_bpl(phba, buf_ptr);`
`5169`		`- elsiocb->bpl_dmabuf = NULL;`
`5170`	`5168`	`}`
`5171`	`5169`	`lpfc_sli_release_iocbq(phba, elsiocb);`
`5172`	`5170`	`return 0;`