Skip to content

Commit 3c497f6

Browse files
remoteproc: imx_dsp_rproc: Fix kernel test robot sparse warning
This patch fixes the kernel test robot warning reported here: https://lore.kernel.org/bpf/642f916b.pPIKZ%2Fl%2F%2Fbw8tvIH%25lkp@intel.com/T/ Fixes: 408ec1f ("remoteproc: imx_dsp_rproc: Add custom memory copy implementation for i.MX DSP Cores") Link: https://lore.kernel.org/r/20230407161429.3973177-1-mathieu.poirier@linaro.org Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 5de6ef4 commit 3c497f6

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/remoteproc/imx_dsp_rproc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -746,12 +746,12 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid)
746746
* The IRAM is part of the HiFi DSP.
747747
* According to hw specs only 32-bits writes are allowed.
748748
*/
749-
static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
749+
static int imx_dsp_rproc_memcpy(void *dst, const void *src, size_t size)
750750
{
751+
void __iomem *dest = (void __iomem *)dst;
751752
const u8 *src_byte = src;
752753
const u32 *source = src;
753754
u32 affected_mask;
754-
u32 *dst = dest;
755755
int i, q, r;
756756
u32 tmp;
757757

@@ -764,7 +764,7 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
764764

765765
/* copy data in units of 32 bits at a time */
766766
for (i = 0; i < q; i++)
767-
writel(source[i], &dst[i]);
767+
writel(source[i], dest + i * 4);
768768

769769
if (r) {
770770
affected_mask = GENMASK(8 * r, 0);
@@ -795,8 +795,8 @@ static int imx_dsp_rproc_memcpy(void *dest, const void *src, size_t size)
795795
*/
796796
static int imx_dsp_rproc_memset(void *addr, u8 value, size_t size)
797797
{
798+
void __iomem *tmp_dst = (void __iomem *)addr;
798799
u32 tmp_val = value;
799-
u32 *tmp_dst = addr;
800800
u32 affected_mask;
801801
int q, r;
802802
u32 tmp;

0 commit comments

Comments
 (0)