Skip to content

Commit 3c4ae63

Browse files
jhovoldgregkh
authored andcommitted
mux: mmio: fix regmap leak on probe failure
The mmio regmap that may be allocated during probe is never freed. Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind. Fixes: 61de83f ("mux: mmio: Do not use syscon helper to build regmap") Cc: stable@vger.kernel.org # 6.16 Cc: Andrew Davis <afd@ti.com> Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Andrew Davis <afd@ti.com> Link: https://patch.msgid.link/20251127134702.1915-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8f96d37 commit 3c4ae63

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/mux/mmio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ static int mux_mmio_probe(struct platform_device *pdev)
7272
if (IS_ERR(base))
7373
regmap = ERR_PTR(-ENODEV);
7474
else
75-
regmap = regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg);
75+
regmap = devm_regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg);
7676
/* Fallback to checking the parent node on "real" errors. */
7777
if (IS_ERR(regmap) && regmap != ERR_PTR(-EPROBE_DEFER)) {
7878
regmap = dev_get_regmap(dev->parent, NULL);

0 commit comments

Comments
 (0)