hwspinlock: add a check of devm_regmap_field_alloc in qcom_hwspinlock_probe

void0red · andersson · commit 3c81195a04e1 · 2023-07-15T12:57:29.000-07:00
devm_regmap_field_alloc may fails, priv field might be error pointer and cause illegal address access later. Signed-off-by: Kang Chen <void0red@gmail.com> Link: https://lore.kernel.org/r/20230227004116.1273988-1-void0red@gmail.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
@@ -197,6 +197,8 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev)
 
 		bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev,
 							     regmap, field);
+		if (IS_ERR(bank->lock[i].priv))
+			return PTR_ERR(bank->lock[i].priv);
 	}
 
 	return devm_hwspin_lock_register(&pdev->dev, bank, &qcom_hwspinlock_ops,

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,8 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev)`
`197`	`197`
`198`	`198`	`bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev,`
`199`	`199`	`regmap, field);`
	`200`	`+ if (IS_ERR(bank->lock[i].priv))`
	`201`	`+ return PTR_ERR(bank->lock[i].priv);`
`200`	`202`	`}`
`201`	`203`
`202`	`204`	`return devm_hwspin_lock_register(&pdev->dev, bank, &qcom_hwspinlock_ops,`