HID: playstation: fix return from dualsense_player_led_set_brightness()

Jiri Kosina · Jiri Kosina · commit 3c92cb4cb60c · 2021-10-27T10:05:07.000+02:00
brightness_set_blocking() callback expects function returning int. This fixes
the follwoing build failure:

drivers/hid/hid-playstation.c: In function ‘dualsense_player_led_set_brightness’:
drivers/hid/hid-playstation.c:885:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^

Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
@@ -882,6 +882,8 @@ static int dualsense_player_led_set_brightness(struct led_classdev *led, enum le
 	spin_unlock_irqrestore(&ds->base.lock, flags);
 
 	schedule_work(&ds->output_worker);
+
+	return 0;
 }
 
 static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp,

Original file line number	Diff line number	Diff line change
`@@ -882,6 +882,8 @@ static int dualsense_player_led_set_brightness(struct led_classdev *led, enum le`
`882`	`882`	`spin_unlock_irqrestore(&ds->base.lock, flags);`
`883`	`883`
`884`	`884`	`schedule_work(&ds->output_worker);`
	`885`	`+`
	`886`	`+ return 0;`
`885`	`887`	`}`
`886`	`888`
`887`	`889`	`static void dualsense_init_output_report(struct dualsense ds, struct dualsense_output_report rp,`