Skip to content

Commit 3cac910

Browse files
eliasrudberggregkh
authored andcommitted
usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct
Remove the unused "u32 vdo[3]" part in the tps6598x_rx_identity_reg struct. This helps avoid "failed to register partner" errors which happen when tps6598x_read_partner_identity() fails because the amount of data read is 12 bytes smaller than the struct size. Note that vdo[3] is already in usb_pd_identity and hence shouldn't be added to tps6598x_rx_identity_reg as well. Fixes: f6c56ca ("usb: typec: Add the Product Type VDOs to struct usb_pd_identity") Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Guido Günther <agx@sigxcpu.org> Signed-off-by: Elias Rudberg <mail@eliasrudberg.se> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210311124710.6563-1-mail@eliasrudberg.se Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 546aa0e commit 3cac910

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/usb/typec/tps6598x.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ enum {
6464
struct tps6598x_rx_identity_reg {
6565
u8 status;
6666
struct usb_pd_identity identity;
67-
u32 vdo[3];
6867
} __packed;
6968

7069
/* Standard Task return codes */

0 commit comments

Comments
 (0)