Skip to content

Commit 3ccffe8

Browse files
rpearsonhpe-designjgunthorpe
authored andcommitted
RDMA/rxe: Move max_elem into rxe_type_info
Move the maximum number of elements from a parameter in rxe_pool_init to a member of the rxe_type_info array. Link: https://lore.kernel.org/r/20220304000808.225811-7-rpearsonhpe@gmail.com Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent b4a47f6 commit 3ccffe8

3 files changed

Lines changed: 20 additions & 20 deletions

File tree

drivers/infiniband/sw/rxe/rxe.c

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -118,43 +118,35 @@ static int rxe_init_pools(struct rxe_dev *rxe)
118118
{
119119
int err;
120120

121-
err = rxe_pool_init(rxe, &rxe->uc_pool, RXE_TYPE_UC,
122-
rxe->max_ucontext);
121+
err = rxe_pool_init(rxe, &rxe->uc_pool, RXE_TYPE_UC);
123122
if (err)
124123
goto err1;
125124

126-
err = rxe_pool_init(rxe, &rxe->pd_pool, RXE_TYPE_PD,
127-
rxe->attr.max_pd);
125+
err = rxe_pool_init(rxe, &rxe->pd_pool, RXE_TYPE_PD);
128126
if (err)
129127
goto err2;
130128

131-
err = rxe_pool_init(rxe, &rxe->ah_pool, RXE_TYPE_AH,
132-
rxe->attr.max_ah);
129+
err = rxe_pool_init(rxe, &rxe->ah_pool, RXE_TYPE_AH);
133130
if (err)
134131
goto err3;
135132

136-
err = rxe_pool_init(rxe, &rxe->srq_pool, RXE_TYPE_SRQ,
137-
rxe->attr.max_srq);
133+
err = rxe_pool_init(rxe, &rxe->srq_pool, RXE_TYPE_SRQ);
138134
if (err)
139135
goto err4;
140136

141-
err = rxe_pool_init(rxe, &rxe->qp_pool, RXE_TYPE_QP,
142-
rxe->attr.max_qp);
137+
err = rxe_pool_init(rxe, &rxe->qp_pool, RXE_TYPE_QP);
143138
if (err)
144139
goto err5;
145140

146-
err = rxe_pool_init(rxe, &rxe->cq_pool, RXE_TYPE_CQ,
147-
rxe->attr.max_cq);
141+
err = rxe_pool_init(rxe, &rxe->cq_pool, RXE_TYPE_CQ);
148142
if (err)
149143
goto err6;
150144

151-
err = rxe_pool_init(rxe, &rxe->mr_pool, RXE_TYPE_MR,
152-
rxe->attr.max_mr);
145+
err = rxe_pool_init(rxe, &rxe->mr_pool, RXE_TYPE_MR);
153146
if (err)
154147
goto err7;
155148

156-
err = rxe_pool_init(rxe, &rxe->mw_pool, RXE_TYPE_MW,
157-
rxe->attr.max_mw);
149+
err = rxe_pool_init(rxe, &rxe->mw_pool, RXE_TYPE_MW);
158150
if (err)
159151
goto err8;
160152

drivers/infiniband/sw/rxe/rxe_pool.c

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,19 @@ static const struct rxe_type_info {
1616
enum rxe_pool_flags flags;
1717
u32 min_index;
1818
u32 max_index;
19+
u32 max_elem;
1920
} rxe_type_info[RXE_NUM_TYPES] = {
2021
[RXE_TYPE_UC] = {
2122
.name = "rxe-uc",
2223
.size = sizeof(struct rxe_ucontext),
2324
.elem_offset = offsetof(struct rxe_ucontext, elem),
25+
.max_elem = UINT_MAX,
2426
},
2527
[RXE_TYPE_PD] = {
2628
.name = "rxe-pd",
2729
.size = sizeof(struct rxe_pd),
2830
.elem_offset = offsetof(struct rxe_pd, elem),
31+
.max_elem = UINT_MAX,
2932
},
3033
[RXE_TYPE_AH] = {
3134
.name = "rxe-ah",
@@ -34,6 +37,7 @@ static const struct rxe_type_info {
3437
.flags = RXE_POOL_INDEX,
3538
.min_index = RXE_MIN_AH_INDEX,
3639
.max_index = RXE_MAX_AH_INDEX,
40+
.max_elem = RXE_MAX_AH_INDEX - RXE_MIN_AH_INDEX + 1,
3741
},
3842
[RXE_TYPE_SRQ] = {
3943
.name = "rxe-srq",
@@ -42,6 +46,7 @@ static const struct rxe_type_info {
4246
.flags = RXE_POOL_INDEX,
4347
.min_index = RXE_MIN_SRQ_INDEX,
4448
.max_index = RXE_MAX_SRQ_INDEX,
49+
.max_elem = RXE_MAX_SRQ_INDEX - RXE_MIN_SRQ_INDEX + 1,
4550
},
4651
[RXE_TYPE_QP] = {
4752
.name = "rxe-qp",
@@ -51,12 +56,14 @@ static const struct rxe_type_info {
5156
.flags = RXE_POOL_INDEX,
5257
.min_index = RXE_MIN_QP_INDEX,
5358
.max_index = RXE_MAX_QP_INDEX,
59+
.max_elem = RXE_MAX_QP_INDEX - RXE_MIN_QP_INDEX + 1,
5460
},
5561
[RXE_TYPE_CQ] = {
5662
.name = "rxe-cq",
5763
.size = sizeof(struct rxe_cq),
5864
.elem_offset = offsetof(struct rxe_cq, elem),
5965
.cleanup = rxe_cq_cleanup,
66+
.max_elem = UINT_MAX,
6067
},
6168
[RXE_TYPE_MR] = {
6269
.name = "rxe-mr",
@@ -66,6 +73,7 @@ static const struct rxe_type_info {
6673
.flags = RXE_POOL_INDEX | RXE_POOL_ALLOC,
6774
.min_index = RXE_MIN_MR_INDEX,
6875
.max_index = RXE_MAX_MR_INDEX,
76+
.max_elem = RXE_MAX_MR_INDEX - RXE_MIN_MR_INDEX + 1,
6977
},
7078
[RXE_TYPE_MW] = {
7179
.name = "rxe-mw",
@@ -75,6 +83,7 @@ static const struct rxe_type_info {
7583
.flags = RXE_POOL_INDEX,
7684
.min_index = RXE_MIN_MW_INDEX,
7785
.max_index = RXE_MAX_MW_INDEX,
86+
.max_elem = RXE_MAX_MW_INDEX - RXE_MIN_MW_INDEX + 1,
7887
},
7988
};
8089

@@ -104,8 +113,7 @@ static int rxe_pool_init_index(struct rxe_pool *pool, u32 max, u32 min)
104113
int rxe_pool_init(
105114
struct rxe_dev *rxe,
106115
struct rxe_pool *pool,
107-
enum rxe_elem_type type,
108-
unsigned int max_elem)
116+
enum rxe_elem_type type)
109117
{
110118
const struct rxe_type_info *info = &rxe_type_info[type];
111119
int err = 0;
@@ -115,7 +123,7 @@ int rxe_pool_init(
115123
pool->rxe = rxe;
116124
pool->name = info->name;
117125
pool->type = type;
118-
pool->max_elem = max_elem;
126+
pool->max_elem = info->max_elem;
119127
pool->elem_size = ALIGN(info->size, RXE_POOL_ALIGN);
120128
pool->elem_offset = info->elem_offset;
121129
pool->flags = info->flags;

drivers/infiniband/sw/rxe/rxe_pool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ struct rxe_pool {
6363
* pool elements will be allocated out of a slab cache
6464
*/
6565
int rxe_pool_init(struct rxe_dev *rxe, struct rxe_pool *pool,
66-
enum rxe_elem_type type, u32 max_elem);
66+
enum rxe_elem_type type);
6767

6868
/* free resources from object pool */
6969
void rxe_pool_cleanup(struct rxe_pool *pool);

0 commit comments

Comments
 (0)