Skip to content

Commit 3cd3b49

Browse files
jhovoldbjorn-helgaas
authored andcommitted
dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again
Commit 756485b ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the bindings, which results in DT checker warnings like: arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected) from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml# Note that this property has been part of the Qualcomm PCIe bindings since 2018 and would need to be deprecated rather than simply removed if there is a desire to replace it with 'vpcie3v3' which is used for some non-Qualcomm controllers. Link: https://lore.kernel.org/lkml/Zp_LPixNnh-2Fy5N@hovoldconsulting.com/ Fixes: 756485b ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema") Link: https://lore.kernel.org/r/20240723151328.684-1-johan+linaro@kernel.org Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
1 parent f500a2f commit 3cd3b49

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ properties:
7878
description: GPIO controlled connection to WAKE# signal
7979
maxItems: 1
8080

81+
vddpe-3v3-supply:
82+
description: PCIe endpoint power supply
83+
8184
required:
8285
- reg
8386
- reg-names

Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ properties:
7474
items:
7575
- const: pci
7676

77-
vddpe-3v3-supply:
78-
description: PCIe endpoint power supply
79-
8077
allOf:
8178
- $ref: qcom,pcie-common.yaml#
8279

Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ properties:
5858
items:
5959
- const: pci
6060

61-
vddpe-3v3-supply:
62-
description: A phandle to the PCIe endpoint power supply
63-
6461
required:
6562
- interconnects
6663
- interconnect-names

Documentation/devicetree/bindings/pci/qcom,pcie.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@ properties:
9191
vdda_refclk-supply:
9292
description: A phandle to the core analog power supply for IC which generates reference clock
9393

94+
vddpe-3v3-supply:
95+
description: A phandle to the PCIe endpoint power supply
96+
9497
phys:
9598
maxItems: 1
9699

0 commit comments

Comments
 (0)