Skip to content

Commit 3d57c44

Browse files
Sergey ShtylyovAnna Schumaker
authored andcommitted
NFSv4: pass lease period in seconds to nfs4_set_lease_period()
There's no need to multiply the lease period by HZ at all the call sites of nfs4_set_lease_period() -- it makes more sense to do that only once, inside that function, by passing to it lease period as 32-bit # of seconds instead of 32/64-bit *unsigned long* # of jiffies... Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
1 parent fdc0396 commit 3d57c44

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

fs/nfs/nfs4_fs.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -477,8 +477,7 @@ struct nfs_client *nfs4_alloc_client(const struct nfs_client_initdata *);
477477
extern void nfs4_schedule_state_renewal(struct nfs_client *);
478478
extern void nfs4_kill_renewd(struct nfs_client *);
479479
extern void nfs4_renew_state(struct work_struct *);
480-
extern void nfs4_set_lease_period(struct nfs_client *clp, unsigned long lease);
481-
480+
extern void nfs4_set_lease_period(struct nfs_client *clp, u32 period);
482481

483482
/* nfs4state.c */
484483
extern const nfs4_stateid current_stateid;

fs/nfs/nfs4proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5487,7 +5487,7 @@ static int nfs4_do_fsinfo(struct nfs_server *server, struct nfs_fh *fhandle, str
54875487
err = _nfs4_do_fsinfo(server, fhandle, fsinfo);
54885488
trace_nfs4_fsinfo(server, fhandle, fsinfo->fattr, err);
54895489
if (err == 0) {
5490-
nfs4_set_lease_period(server->nfs_client, fsinfo->lease_time * HZ);
5490+
nfs4_set_lease_period(server->nfs_client, fsinfo->lease_time);
54915491
break;
54925492
}
54935493
err = nfs4_handle_exception(server, err, &exception);

fs/nfs/nfs4renewd.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,12 @@ nfs4_kill_renewd(struct nfs_client *clp)
137137
* nfs4_set_lease_period - Sets the lease period on a nfs_client
138138
*
139139
* @clp: pointer to nfs_client
140-
* @lease: new value for lease period
140+
* @period: new value for lease period (in seconds)
141141
*/
142-
void nfs4_set_lease_period(struct nfs_client *clp,
143-
unsigned long lease)
142+
void nfs4_set_lease_period(struct nfs_client *clp, u32 period)
144143
{
144+
unsigned long lease = period * HZ;
145+
145146
spin_lock(&clp->cl_lock);
146147
clp->cl_lease_time = lease;
147148
spin_unlock(&clp->cl_lock);

fs/nfs/nfs4state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ static int nfs4_setup_state_renewal(struct nfs_client *clp)
104104

105105
status = nfs4_proc_get_lease_time(clp, &fsinfo);
106106
if (status == 0) {
107-
nfs4_set_lease_period(clp, fsinfo.lease_time * HZ);
107+
nfs4_set_lease_period(clp, fsinfo.lease_time);
108108
nfs4_schedule_state_renewal(clp);
109109
}
110110

0 commit comments

Comments
 (0)