Skip to content

Commit 3d72bb4

Browse files
q2vendavem330
authored andcommitted
udp: Fix a data-race around sysctl_udp_l3mdev_accept.
While reading sysctl_udp_l3mdev_accept, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes: 63a6fff ("net: Avoid receiving packets with an l3mdev on unbound UDP sockets") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 9b55c20 commit 3d72bb4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

include/net/udp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ static inline bool udp_sk_bound_dev_eq(struct net *net, int bound_dev_if,
238238
int dif, int sdif)
239239
{
240240
#if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV)
241-
return inet_bound_dev_eq(!!net->ipv4.sysctl_udp_l3mdev_accept,
241+
return inet_bound_dev_eq(!!READ_ONCE(net->ipv4.sysctl_udp_l3mdev_accept),
242242
bound_dev_if, dif, sdif);
243243
#else
244244
return inet_bound_dev_eq(true, bound_dev_if, dif, sdif);

0 commit comments

Comments
 (0)