Skip to content

Commit 3d778e6

Browse files
Jiawen Wukuba-moo
authored andcommitted
net: txgbe: remove the redundant data return in SW-FW mailbox
For these two firmware mailbox commands, in txgbe_test_hostif() and txgbe_set_phy_link_hostif(), there is no need to read data from the buffer. Under the current setting, OEM firmware will cause the driver to fail to probe. Because OEM firmware returns more link information, with a larger OEM structure txgbe_hic_ephy_getlink. However, the current driver does not support the OEM function. So just fix it in the way that does not involve reading the returned data. Fixes: d84a3ff ("net: txgbe: Restrict the use of mismatched FW versions") Cc: stable@vger.kernel.org Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Link: https://patch.msgid.link/2914AB0BC6158DDA+20260119065935.6015-1-jiawenwu@trustnetic.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9d11e97 commit 3d778e6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ int txgbe_test_hostif(struct wx *wx)
7070
buffer.hdr.cmd_or_resp.cmd_resv = FW_CEM_CMD_RESERVED;
7171

7272
return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer),
73-
WX_HI_COMMAND_TIMEOUT, true);
73+
WX_HI_COMMAND_TIMEOUT, false);
7474
}
7575

7676
int txgbe_read_eeprom_hostif(struct wx *wx,
@@ -148,7 +148,7 @@ static int txgbe_set_phy_link_hostif(struct wx *wx, int speed, int autoneg, int
148148
buffer.duplex = duplex;
149149

150150
return wx_host_interface_command(wx, (u32 *)&buffer, sizeof(buffer),
151-
WX_HI_COMMAND_TIMEOUT, true);
151+
WX_HI_COMMAND_TIMEOUT, false);
152152
}
153153

154154
static void txgbe_get_link_capabilities(struct wx *wx, int *speed,

0 commit comments

Comments
 (0)