mtd: parsers: qcom: Fix missing free for pparts in cleanup

Ansuel · miquelraynal · commit 3dd8ba961b93 · 2022-01-25T10:32:07.000+01:00
Mtdpart doesn't free pparts when a cleanup function is declared. Add missing free for pparts in cleanup function for smem to fix the leak. Fixes: 10f3b4d ("mtd: parsers: qcom: Fix leaking of partition name") Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20220116032211.9728-2-ansuelsmth@gmail.com
diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c
@@ -174,6 +174,8 @@ static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,
 
 	for (i = 0; i < nr_parts; i++)
 		kfree(pparts[i].name);
+
+	kfree(pparts);
 }
 
 static const struct of_device_id qcomsmem_of_match_table[] = {

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,8 @@ static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,`
`174`	`174`
`175`	`175`	`for (i = 0; i < nr_parts; i++)`
`176`	`176`	`kfree(pparts[i].name);`
	`177`	`+`
	`178`	`+ kfree(pparts);`
`177`	`179`	`}`
`178`	`180`
`179`	`181`	`static const struct of_device_id qcomsmem_of_match_table[] = {`