Skip to content

Commit 3de990f

Browse files
Mukesh Ojhaandersson
authored andcommitted
firmware: qcom: scm: Remove log reporting memory allocation failure
Remove redundant memory allocation failure. WARNING: Possible unnecessary 'out of memory' message + if (!mdata_buf) { + dev_err(__scm->dev, "Allocation of metadata buffer failed.\n"); Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/1711034642-22860-1-git-send-email-quic_mojha@quicinc.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent d6cbce2 commit 3de990f

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/firmware/qcom/qcom_scm.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -554,10 +554,9 @@ int qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size,
554554
*/
555555
mdata_buf = dma_alloc_coherent(__scm->dev, size, &mdata_phys,
556556
GFP_KERNEL);
557-
if (!mdata_buf) {
558-
dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");
557+
if (!mdata_buf)
559558
return -ENOMEM;
560-
}
559+
561560
memcpy(mdata_buf, metadata, size);
562561

563562
ret = qcom_scm_clk_enable();

0 commit comments

Comments
 (0)