Skip to content

Commit 3df1fd3

Browse files
Kotbenekgregkh
authored andcommitted
gpib: tnt4882: Unify *allocate_private usage
Use the return value of tnt4882_allocate_private in calling code as early return value in case of error. Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com> Link: https://patch.msgid.link/20260116174647.317256-28-dominik.karol.piatkowski@protonmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9effb86 commit 3df1fd3

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

drivers/gpib/tnt4882/tnt4882_gpib.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -915,8 +915,9 @@ static int ni_pci_attach(struct gpib_board *board, const struct gpib_board_confi
915915

916916
board->status = 0;
917917

918-
if (tnt4882_allocate_private(board))
919-
return -ENOMEM;
918+
retval = tnt4882_allocate_private(board);
919+
if (retval)
920+
return retval;
920921
tnt_priv = board->private_data;
921922
nec_priv = &tnt_priv->nec7210_priv;
922923
nec_priv->type = TNT4882;
@@ -1038,8 +1039,9 @@ static int ni_isa_attach_common(struct gpib_board *board, const struct gpib_boar
10381039

10391040
board->status = 0;
10401041

1041-
if (tnt4882_allocate_private(board))
1042-
return -ENOMEM;
1042+
retval = tnt4882_allocate_private(board);
1043+
if (retval)
1044+
return retval;
10431045
tnt_priv = board->private_data;
10441046
nec_priv = &tnt_priv->nec7210_priv;
10451047
nec_priv->type = chipset;
@@ -1724,8 +1726,9 @@ static int ni_pcmcia_attach(struct gpib_board *board, const struct gpib_board_co
17241726

17251727
board->status = 0;
17261728

1727-
if (tnt4882_allocate_private(board))
1728-
return -ENOMEM;
1729+
retval = tnt4882_allocate_private(board);
1730+
if (retval)
1731+
return retval;
17291732

17301733
tnt_priv = board->private_data;
17311734
nec_priv = &tnt_priv->nec7210_priv;

0 commit comments

Comments
 (0)