Skip to content

Commit 3ef4d9e

Browse files
jhovoldbroonie
authored andcommitted
ASoC: codecs: wcd939x: fix OF node leaks on probe failure
The component match entry release function will drop the references taken while looking up the soundwire OF nodes when the platform device is unbound. Drop the additional references taken to avoid leaking them on probe failure (e.g. probe deferral) and on driver unbind. Fixes: 10f514b ("ASoC: codecs: Add WCD939x Codec driver") Cc: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Link: https://patch.msgid.link/20251201093419.24474-4-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 32ae6eb commit 3ef4d9e

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

sound/soc/codecs/wcd939x.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3526,7 +3526,6 @@ static int wcd939x_add_slave_components(struct wcd939x_priv *wcd939x,
35263526
return -ENODEV;
35273527
}
35283528

3529-
of_node_get(wcd939x->rxnode);
35303529
component_match_add_release(dev, matchptr, component_release_of,
35313530
component_compare_of, wcd939x->rxnode);
35323531

@@ -3535,7 +3534,7 @@ static int wcd939x_add_slave_components(struct wcd939x_priv *wcd939x,
35353534
dev_err(dev, "%s: Tx-device node not defined\n", __func__);
35363535
return -ENODEV;
35373536
}
3538-
of_node_get(wcd939x->txnode);
3537+
35393538
component_match_add_release(dev, matchptr, component_release_of,
35403539
component_compare_of, wcd939x->txnode);
35413540
return 0;

0 commit comments

Comments
 (0)