Skip to content

Commit 3f1bff1

Browse files
gentoo-rootkuba-moo
authored andcommitted
bnxt_en: Remove jumbo_remove step from TX path
Now that the kernel doesn't insert HBH for BIG TCP IPv6 packets, remove unnecessary steps from the bnxt_en TX path, that used to check and remove HBH. Signed-off-by: Alice Mikityanska <alice@isovalent.com> Acked-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20260205133925.526371-9-alice.kernel@fastmail.im Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 8b76102 commit 3f1bff1

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

  • drivers/net/ethernet/broadcom/bnxt

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -517,9 +517,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
517517
return NETDEV_TX_BUSY;
518518
}
519519

520-
if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
521-
goto tx_free;
522-
523520
length = skb->len;
524521
len = skb_headlen(skb);
525522
last_frag = skb_shinfo(skb)->nr_frags;
@@ -13881,7 +13878,6 @@ static bool bnxt_exthdr_check(struct bnxt *bp, struct sk_buff *skb, int nw_off,
1388113878
u8 **nextp)
1388213879
{
1388313880
struct ipv6hdr *ip6h = (struct ipv6hdr *)(skb->data + nw_off);
13884-
struct hop_jumbo_hdr *jhdr;
1388513881
int hdr_count = 0;
1388613882
u8 *nexthdr;
1388713883
int start;
@@ -13910,24 +13906,7 @@ static bool bnxt_exthdr_check(struct bnxt *bp, struct sk_buff *skb, int nw_off,
1391013906
if (hdrlen > 64)
1391113907
return false;
1391213908

13913-
/* The ext header may be a hop-by-hop header inserted for
13914-
* big TCP purposes. This will be removed before sending
13915-
* from NIC, so do not count it.
13916-
*/
13917-
if (*nexthdr == NEXTHDR_HOP) {
13918-
if (likely(skb->len <= GRO_LEGACY_MAX_SIZE))
13919-
goto increment_hdr;
13920-
13921-
jhdr = (struct hop_jumbo_hdr *)hp;
13922-
if (jhdr->tlv_type != IPV6_TLV_JUMBO || jhdr->hdrlen != 0 ||
13923-
jhdr->nexthdr != IPPROTO_TCP)
13924-
goto increment_hdr;
13925-
13926-
goto next_hdr;
13927-
}
13928-
increment_hdr:
1392913909
hdr_count++;
13930-
next_hdr:
1393113910
nexthdr = &hp->nexthdr;
1393213911
start += hdrlen;
1393313912
}

0 commit comments

Comments
 (0)