selftests/efivarfs: create-read: fix a resource leak

zhujun2 · shuahkh · commit 3f6f8a8c5e11 · 2023-10-18T14:33:44.000-06:00
The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 &lt;zhujun2@cmss.chinamobile.com&gt;
Signed-off-by: Shuah Khan &lt;skhan@linuxfoundation.org&gt;
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,10 @@ int main(int argc, char **argv)
 	rc = read(fd, buf, sizeof(buf));
 	if (rc != 0) {
 		fprintf(stderr, "Reading a new var should return EOF\n");
+		close(fd);
 		return EXIT_FAILURE;
 	}
 
+	close(fd);
 	return EXIT_SUCCESS;
 }

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,10 @@ int main(int argc, char **argv)`
`32`	`32`	`rc = read(fd, buf, sizeof(buf));`
`33`	`33`	`if (rc != 0) {`
`34`	`34`	`fprintf(stderr, "Reading a new var should return EOF\n");`
	`35`	`+ close(fd);`
`35`	`36`	`return EXIT_FAILURE;`
`36`	`37`	`}`
`37`	`38`
	`39`	`+ close(fd);`
`38`	`40`	`return EXIT_SUCCESS;`
`39`	`41`	`}`