Skip to content

Commit 404500b

Browse files
yunfei-mtkmchehab
authored andcommitted
media: mediatek: vcodec: Add debug params to control different log level
Add parameter mtk_vcodec_dbg to open each codec log. Add parameter mtk_v4l2_dbg_level to open each instance log according to the parameter value. Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> [hverkuil: add () around 'level' in macro] Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent 7866e12 commit 404500b

3 files changed

Lines changed: 33 additions & 3 deletions

File tree

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ void mtk_vcodec_dbgfs_init(struct mtk_vcodec_dev *vcodec_dev)
2020
IS_ERR(vcodec_dev->dbgfs.vcodec_root));
2121

2222
vcodec_root = vcodec_dev->dbgfs.vcodec_root;
23+
debugfs_create_x32("mtk_v4l2_dbg_level", 0644, vcodec_root, &mtk_v4l2_dbg_level);
24+
debugfs_create_x32("mtk_vcodec_dbg", 0644, vcodec_root, &mtk_vcodec_dbg);
2325
}
2426
EXPORT_SYMBOL_GPL(mtk_vcodec_dbgfs_init);
2527

drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@
1313
#include "mtk_vcodec_drv.h"
1414
#include "mtk_vcodec_util.h"
1515

16+
#if defined(CONFIG_DEBUG_FS)
17+
int mtk_vcodec_dbg;
18+
EXPORT_SYMBOL(mtk_vcodec_dbg);
19+
20+
int mtk_v4l2_dbg_level;
21+
EXPORT_SYMBOL(mtk_v4l2_dbg_level);
22+
#endif
23+
1624
void __iomem *mtk_vcodec_get_reg_addr(struct mtk_vcodec_ctx *data,
1725
unsigned int reg_idx)
1826
{

drivers/media/platform/mediatek/vcodec/mtk_vcodec_util.h

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,35 @@ struct mtk_vcodec_dev;
3535
pr_err("[MTK_VCODEC][ERROR][%d]: " fmt "\n", \
3636
((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
3737

38+
#if defined(CONFIG_DEBUG_FS)
39+
extern int mtk_v4l2_dbg_level;
40+
extern int mtk_vcodec_dbg;
3841

39-
#define mtk_v4l2_debug(level, fmt, args...) pr_debug(fmt, ##args)
42+
#define mtk_v4l2_debug(level, fmt, args...) \
43+
do { \
44+
if (mtk_v4l2_dbg_level >= (level)) \
45+
pr_debug("[MTK_V4L2] %s, %d: " fmt "\n", \
46+
__func__, __LINE__, ##args); \
47+
} while (0)
4048

41-
#define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+")
42-
#define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-")
49+
#define mtk_vcodec_debug(h, fmt, args...) \
50+
do { \
51+
if (mtk_vcodec_dbg) \
52+
dev_dbg(&(((struct mtk_vcodec_ctx *)(h)->ctx)->dev->plat_dev->dev), \
53+
"[MTK_VCODEC][%d]: %s, %d " fmt "\n", \
54+
((struct mtk_vcodec_ctx *)(h)->ctx)->id, \
55+
__func__, __LINE__, ##args); \
56+
} while (0)
57+
#else
58+
#define mtk_v4l2_debug(level, fmt, args...) pr_debug(fmt, ##args)
4359

4460
#define mtk_vcodec_debug(h, fmt, args...) \
4561
pr_debug("[MTK_VCODEC][%d]: " fmt "\n", \
4662
((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
63+
#endif
64+
65+
#define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+")
66+
#define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-")
4767

4868
#define mtk_vcodec_debug_enter(h) mtk_vcodec_debug(h, "+")
4969
#define mtk_vcodec_debug_leave(h) mtk_vcodec_debug(h, "-")

0 commit comments

Comments
 (0)