Skip to content

Commit 4060581

Browse files
author
Andreas Gruenbacher
committed
Revert "gfs2: Force withdraw to replay journals and wait for it to finish" (5/6)
The current withdraw code duplicates the journal recovery code gfs2 already has for dealing with node failures, and it does so poorly. That code was added because when releasing a lockspace, we didn't have a way to indicate that the lockspace needs recovery. We now do have this feature, so the current withdraw code can be removed almost entirely. This is one of several steps towards that. Reverts parts of commit 601ef0d ("gfs2: Force withdraw to replay journals and wait for it to finish"). Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
1 parent a07a1e4 commit 4060581

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

fs/gfs2/glock.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -691,8 +691,7 @@ __acquires(&gl->gl_lockref.lock)
691691
struct lm_lockstruct *ls = &sdp->sd_lockstruct;
692692
int ret;
693693

694-
if (target != LM_ST_UNLOCKED && glock_blocked_by_withdraw(gl) &&
695-
gh && !(gh->gh_flags & LM_FLAG_RECOVER))
694+
if (target != LM_ST_UNLOCKED && glock_blocked_by_withdraw(gl))
696695
goto skip_inval;
697696

698697
GLOCK_BUG_ON(gl, gl->gl_state == target);
@@ -1548,7 +1547,7 @@ int gfs2_glock_nq(struct gfs2_holder *gh)
15481547
struct gfs2_glock *gl = gh->gh_gl;
15491548
int error;
15501549

1551-
if (glock_blocked_by_withdraw(gl) && !(gh->gh_flags & LM_FLAG_RECOVER))
1550+
if (glock_blocked_by_withdraw(gl))
15521551
return -EIO;
15531552

15541553
if (gh->gh_flags & GL_NOBLOCK) {

0 commit comments

Comments
 (0)