Skip to content

Commit 414c20d

Browse files
Wei Yongjungregkh
authored andcommitted
USB: gadget: udc: s3c2410_udc: fix return value check in s3c2410_udc_probe()
In case of error, the function devm_platform_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 188db44 ("usb: gadget: s3c: use platform resources") Cc: stable <stable@vger.kernel.org> Reported-by: Hulk Robot <hulkci@huawei.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Link: https://lore.kernel.org/r/20210305034927.3232386-1-weiyongjun1@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b1d25e6 commit 414c20d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/usb/gadget/udc/s3c2410_udc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1773,8 +1773,8 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
17731773
udc_info = dev_get_platdata(&pdev->dev);
17741774

17751775
base_addr = devm_platform_ioremap_resource(pdev, 0);
1776-
if (!base_addr) {
1777-
retval = -ENOMEM;
1776+
if (IS_ERR(base_addr)) {
1777+
retval = PTR_ERR(base_addr);
17781778
goto err_mem;
17791779
}
17801780

0 commit comments

Comments
 (0)