Skip to content

Commit 41e4f80

Browse files
robherringtmlind
authored andcommitted
bus: ti-sysc: Remove open coded "ranges" parsing
"ranges" is a standard property and we have common helper functions for parsing it, so let's use them. Signed-off-by: Rob Herring <robh@kernel.org> Message-Id: <20230201220002.246907-1-robh@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com>
1 parent fe15c26 commit 41e4f80

1 file changed

Lines changed: 9 additions & 32 deletions

File tree

drivers/bus/ti-sysc.c

Lines changed: 9 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -648,43 +648,20 @@ static int sysc_init_resets(struct sysc *ddata)
648648
static int sysc_parse_and_check_child_range(struct sysc *ddata)
649649
{
650650
struct device_node *np = ddata->dev->of_node;
651-
const __be32 *ranges;
652-
u32 nr_addr, nr_size;
653-
int len, error;
654-
655-
ranges = of_get_property(np, "ranges", &len);
656-
if (!ranges) {
657-
dev_err(ddata->dev, "missing ranges for %pOF\n", np);
658-
659-
return -ENOENT;
660-
}
661-
662-
len /= sizeof(*ranges);
663-
664-
if (len < 3) {
665-
dev_err(ddata->dev, "incomplete ranges for %pOF\n", np);
666-
667-
return -EINVAL;
668-
}
669-
670-
error = of_property_read_u32(np, "#address-cells", &nr_addr);
671-
if (error)
672-
return -ENOENT;
651+
struct of_range_parser parser;
652+
struct of_range range;
653+
int error;
673654

674-
error = of_property_read_u32(np, "#size-cells", &nr_size);
655+
error = of_range_parser_init(&parser, np);
675656
if (error)
676-
return -ENOENT;
677-
678-
if (nr_addr != 1 || nr_size != 1) {
679-
dev_err(ddata->dev, "invalid ranges for %pOF\n", np);
657+
return error;
680658

681-
return -EINVAL;
659+
for_each_of_range(&parser, &range) {
660+
ddata->module_pa = range.cpu_addr;
661+
ddata->module_size = range.size;
662+
break;
682663
}
683664

684-
ranges++;
685-
ddata->module_pa = of_translate_address(np, ranges++);
686-
ddata->module_size = be32_to_cpup(ranges);
687-
688665
return 0;
689666
}
690667

0 commit comments

Comments
 (0)