Skip to content

Commit 4200f87

Browse files
iuliana-prodanmathieupoirier
authored andcommitted
remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW_CONFIRMATION is set
The DSP suspend path currently waits unconditionally for a suspend ack from the firmware. This breaks firmwares that do not implement the mailbox-based CONFIRMATION handshake, as the DSP never responds and system suspend fails with -EBUSY. The driver already uses the WAIT_FW_CONFIRMATION flag to indicate that the firmware supports the CONFIRMATION handshake at boot. Apply the same logic during suspend: only send the suspend message and wait for the suspend ack when the firmware is expected to support it. Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Link: https://lore.kernel.org/r/20251204122825.756106-3-iuliana.prodan@oss.nxp.com Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 424f22b commit 4200f87

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/remoteproc/imx_dsp_rproc.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1251,6 +1251,12 @@ static int imx_dsp_suspend(struct device *dev)
12511251
goto out;
12521252
}
12531253

1254+
/* No fw confirmation expected, so trigger PM runtime suspend */
1255+
if (!(priv->flags & WAIT_FW_CONFIRMATION)) {
1256+
dev_dbg(dev, "No FW_CONFIRMATION needed, suspend directly.\n");
1257+
goto out;
1258+
}
1259+
12541260
reinit_completion(&priv->pm_comp);
12551261

12561262
/* Tell DSP that suspend is happening */

0 commit comments

Comments
 (0)