Skip to content

Commit 42066c4

Browse files
mpacuszxkuba-moo
authored andcommitted
ice: Fix safe mode when DDP is missing
One thing is broken in the safe mode, that is ice_deinit_features() is being executed even that ice_init_features() was not causing stack trace during pci_unregister_driver(). Add check on the top of the function. Fixes: 5b246e5 ("ice: split probe into smaller functions") Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@intel.com> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Link: https://lore.kernel.org/r/20231011233334.336092-4-jacob.e.keller@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 0288c3e commit 42066c4

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4684,6 +4684,9 @@ static void ice_init_features(struct ice_pf *pf)
46844684

46854685
static void ice_deinit_features(struct ice_pf *pf)
46864686
{
4687+
if (ice_is_safe_mode(pf))
4688+
return;
4689+
46874690
ice_deinit_lag(pf);
46884691
if (test_bit(ICE_FLAG_DCB_CAPABLE, pf->flags))
46894692
ice_cfg_lldp_mib_change(&pf->hw, false);

0 commit comments

Comments
 (0)