ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control

broonie · broonie · commit 4213ff556740 · 2022-05-03T13:42:27.000+01:00
The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown <broonie@kernel.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c
@@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol,
 		}
 	}
 
-	return 0;
+	return 1;
 }
 
 static const struct snd_kcontrol_new rt5514_snd_controls[] = {

Original file line number	Diff line number	Diff line change
`@@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol,`
`419`	`419`	`}`
`420`	`420`	`}`
`421`	`421`
`422`		`- return 0;`
	`422`	`+ return 1;`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`static const struct snd_kcontrol_new rt5514_snd_controls[] = {`