pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name()

juhosg · Linus Walleij · commit 4229c28323db · 2025-05-15T00:18:14.000+02:00
The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz <kaloz@openwrt.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev,
 
 	val = grp->val[func];
 
-	regmap_update_bits(info->regmap, reg, mask, val);
-
-	return 0;
+	return regmap_update_bits(info->regmap, reg, mask, val);
 }
 
 static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,

Original file line number	Diff line number	Diff line change
`@@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev,`
`358`	`358`
`359`	`359`	`val = grp->val[func];`
`360`	`360`
`361`		`- regmap_update_bits(info->regmap, reg, mask, val);`
`362`		`-`
`363`		`- return 0;`
	`361`	`+ return regmap_update_bits(info->regmap, reg, mask, val);`
`364`	`362`	`}`
`365`	`363`
`366`	`364`	`static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,`