Skip to content

Commit 424b3d7

Browse files
Guchun Chenalexdeucher
authored andcommitted
drm/amd/pm: downgrade log level upon SMU IF version mismatch
SMU IF version mismatch as a warning message exists widely after asic production, however, due to this log level setting, such mismatch warning will be caught by automation test like IGT and reported as a fake error after checking. As such mismatch does not break anything, to reduce confusion, downgrade it from dev_warn to dev_info. Signed-off-by: Guchun Chen <guchun.chen@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent b1e9a71 commit 424b3d7

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,15 +256,15 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)
256256
* to be backward compatible.
257257
* 2. New fw usually brings some optimizations. But that's visible
258258
* only on the paired driver.
259-
* Considering above, we just leave user a warning message instead
259+
* Considering above, we just leave user a verbal message instead
260260
* of halt driver loading.
261261
*/
262262
if (if_version != smu->smc_driver_if_version) {
263263
dev_info(smu->adev->dev, "smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
264264
"smu fw program = %d, version = 0x%08x (%d.%d.%d)\n",
265265
smu->smc_driver_if_version, if_version,
266266
smu_program, smu_version, smu_major, smu_minor, smu_debug);
267-
dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
267+
dev_info(smu->adev->dev, "SMU driver if version not matched\n");
268268
}
269269

270270
return ret;

drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,15 @@ int smu_v12_0_check_fw_version(struct smu_context *smu)
9393
* to be backward compatible.
9494
* 2. New fw usually brings some optimizations. But that's visible
9595
* only on the paired driver.
96-
* Considering above, we just leave user a warning message instead
96+
* Considering above, we just leave user a verbal message instead
9797
* of halt driver loading.
9898
*/
9999
if (if_version != smu->smc_driver_if_version) {
100100
dev_info(smu->adev->dev, "smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
101101
"smu fw program = %d, smu fw version = 0x%08x (%d.%d.%d)\n",
102102
smu->smc_driver_if_version, if_version,
103103
smu_program, smu_version, smu_major, smu_minor, smu_debug);
104-
dev_warn(smu->adev->dev, "SMU driver if version not matched\n");
104+
dev_info(smu->adev->dev, "SMU driver if version not matched\n");
105105
}
106106

107107
return ret;

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,15 +311,15 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
311311
* to be backward compatible.
312312
* 2. New fw usually brings some optimizations. But that's visible
313313
* only on the paired driver.
314-
* Considering above, we just leave user a warning message instead
314+
* Considering above, we just leave user a verbal message instead
315315
* of halt driver loading.
316316
*/
317317
if (if_version != smu->smc_driver_if_version) {
318318
dev_info(adev->dev, "smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
319319
"smu fw program = %d, smu fw version = 0x%08x (%d.%d.%d)\n",
320320
smu->smc_driver_if_version, if_version,
321321
smu_program, smu_version, smu_major, smu_minor, smu_debug);
322-
dev_warn(adev->dev, "SMU driver if version not matched\n");
322+
dev_info(adev->dev, "SMU driver if version not matched\n");
323323
}
324324

325325
return ret;

0 commit comments

Comments
 (0)