Skip to content

Commit 425c075

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: mediatek-gen3: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-7-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Jianjun Wang <jianjun.wang@mediatek.com> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 363d53a commit 425c075

1 file changed

Lines changed: 3 additions & 10 deletions

File tree

drivers/pci/controller/pcie-mediatek-gen3.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -424,12 +424,6 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie)
424424
return 0;
425425
}
426426

427-
static int mtk_pcie_set_affinity(struct irq_data *data,
428-
const struct cpumask *mask, bool force)
429-
{
430-
return -EINVAL;
431-
}
432-
433427
static void mtk_pcie_msi_irq_mask(struct irq_data *data)
434428
{
435429
pci_msi_mask_irq(data);
@@ -450,8 +444,9 @@ static struct irq_chip mtk_msi_irq_chip = {
450444
};
451445

452446
static struct msi_domain_info mtk_msi_domain_info = {
453-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
454-
MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
447+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
448+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX |
449+
MSI_FLAG_MULTI_PCI_MSI,
455450
.chip = &mtk_msi_irq_chip,
456451
};
457452

@@ -517,7 +512,6 @@ static struct irq_chip mtk_msi_bottom_irq_chip = {
517512
.irq_mask = mtk_msi_bottom_irq_mask,
518513
.irq_unmask = mtk_msi_bottom_irq_unmask,
519514
.irq_compose_msi_msg = mtk_compose_msi_msg,
520-
.irq_set_affinity = mtk_pcie_set_affinity,
521515
.name = "MSI",
522516
};
523517

@@ -618,7 +612,6 @@ static struct irq_chip mtk_intx_irq_chip = {
618612
.irq_mask = mtk_intx_mask,
619613
.irq_unmask = mtk_intx_unmask,
620614
.irq_eoi = mtk_intx_eoi,
621-
.irq_set_affinity = mtk_pcie_set_affinity,
622615
.name = "INTx",
623616
};
624617

0 commit comments

Comments
 (0)