apparmor: Fix uninitialized symbol 'array_size' in policy_unpack_test.c

jrjohansen · jrjohansen · commit 4295c60bbe9e · 2022-11-01T21:23:05.000-07:00
Make sure array_size is initialized in the kunit test to get rid of
compiler warnings. This will also make sure the following tests fail
consistently if the first test fails.

Reported-by: kernel test robot &lt;lkp@intel.com&gt;
Signed-off-by: John Johansen &lt;john.johansen@canonical.com&gt;
diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c
@@ -140,7 +140,7 @@ static void policy_unpack_test_inbounds_when_out_of_bounds(struct kunit *test)
 static void policy_unpack_test_unpack_array_with_null_name(struct kunit *test)
 {
 	struct policy_unpack_fixture *puf = test->priv;
-	u16 array_size;
+	u16 array_size = 0;
 
 	puf->e->pos += TEST_ARRAY_BUF_OFFSET;
 
@@ -155,7 +155,7 @@ static void policy_unpack_test_unpack_array_with_name(struct kunit *test)
 {
 	struct policy_unpack_fixture *puf = test->priv;
 	const char name[] = TEST_ARRAY_NAME;
-	u16 array_size;
+	u16 array_size = 0;
 
 	puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;
 

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ static void policy_unpack_test_inbounds_when_out_of_bounds(struct kunit *test)`
`140`	`140`	`static void policy_unpack_test_unpack_array_with_null_name(struct kunit *test)`
`141`	`141`	`{`
`142`	`142`	`struct policy_unpack_fixture *puf = test->priv;`
`143`		`- u16 array_size;`
	`143`	`+ u16 array_size = 0;`
`144`	`144`
`145`	`145`	`puf->e->pos += TEST_ARRAY_BUF_OFFSET;`
`146`	`146`
`@@ -155,7 +155,7 @@ static void policy_unpack_test_unpack_array_with_name(struct kunit *test)`
`155`	`155`	`{`
`156`	`156`	`struct policy_unpack_fixture *puf = test->priv;`
`157`	`157`	`const char name[] = TEST_ARRAY_NAME;`
`158`		`- u16 array_size;`
	`158`	`+ u16 array_size = 0;`
`159`	`159`
`160`	`160`	`puf->e->pos += TEST_NAMED_ARRAY_BUF_OFFSET;`
`161`	`161`