Skip to content

Commit 4323516

Browse files
jhovoldarndb
authored andcommitted
firmware/psci: demote suspend-mode warning to info level
On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with PSCI_RET_DENIED and since commit 998fcd0 ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level: psci: failed to set PC mode: -3 As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug: psci: [Firmware Bug]: failed to set PC mode: -3 Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Mark Rutland <mark.rutland@arm.com> Acked-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent 4f7e22b commit 4323516

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/firmware/psci/psci.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable)
167167

168168
err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0);
169169
if (err < 0)
170-
pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err);
170+
pr_info(FW_BUG "failed to set %s mode: %d\n",
171+
enable ? "OSI" : "PC", err);
171172
return psci_to_linux_errno(err);
172173
}
173174

0 commit comments

Comments
 (0)