Skip to content

Commit 432418b

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_chardev: Remove redundant struct field
`ec_dev` in the `struct chardev_data` is unused. Remove the field and the whole struct as well. Link: https://lore.kernel.org/r/20250721044456.2736300-2-tzungbi@kernel.org Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
1 parent 8f5ae30 commit 432418b

1 file changed

Lines changed: 11 additions & 17 deletions

File tree

drivers/platform/chrome/cros_ec_chardev.c

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@
3131
/* Arbitrary bounded size for the event queue */
3232
#define CROS_MAX_EVENT_LEN PAGE_SIZE
3333

34-
struct chardev_data {
35-
struct cros_ec_dev *ec_dev;
36-
struct miscdevice misc;
37-
};
38-
3934
struct chardev_priv {
4035
struct cros_ec_dev *ec_dev;
4136
struct notifier_block notifier;
@@ -379,29 +374,28 @@ static int cros_ec_chardev_probe(struct platform_device *pdev)
379374
{
380375
struct cros_ec_dev *ec_dev = dev_get_drvdata(pdev->dev.parent);
381376
struct cros_ec_platform *ec_platform = dev_get_platdata(ec_dev->dev);
382-
struct chardev_data *data;
377+
struct miscdevice *misc;
383378

384379
/* Create a char device: we want to create it anew */
385-
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
386-
if (!data)
380+
misc = devm_kzalloc(&pdev->dev, sizeof(*misc), GFP_KERNEL);
381+
if (!misc)
387382
return -ENOMEM;
388383

389-
data->ec_dev = ec_dev;
390-
data->misc.minor = MISC_DYNAMIC_MINOR;
391-
data->misc.fops = &chardev_fops;
392-
data->misc.name = ec_platform->ec_name;
393-
data->misc.parent = pdev->dev.parent;
384+
misc->minor = MISC_DYNAMIC_MINOR;
385+
misc->fops = &chardev_fops;
386+
misc->name = ec_platform->ec_name;
387+
misc->parent = pdev->dev.parent;
394388

395-
dev_set_drvdata(&pdev->dev, data);
389+
dev_set_drvdata(&pdev->dev, misc);
396390

397-
return misc_register(&data->misc);
391+
return misc_register(misc);
398392
}
399393

400394
static void cros_ec_chardev_remove(struct platform_device *pdev)
401395
{
402-
struct chardev_data *data = dev_get_drvdata(&pdev->dev);
396+
struct miscdevice *misc = dev_get_drvdata(&pdev->dev);
403397

404-
misc_deregister(&data->misc);
398+
misc_deregister(misc);
405399
}
406400

407401
static const struct platform_device_id cros_ec_chardev_id[] = {

0 commit comments

Comments
 (0)