Skip to content

Commit 43f20b1

Browse files
Marc Zyngiermmind
authored andcommitted
arm64: dts: rockchip: Fix PCIe DT properties on rk3399
It recently became apparent that the lack of a 'device_type = "pci"' in the PCIe root complex node for rk3399 is a violation of the PCI binding, as documented in IEEE Std 1275-1994. Changes to the kernel's parsing of the DT made such violation fatal, as drivers cannot probe the controller anymore. Add the missing property makes the PCIe node compliant. While we are at it, drop the pointless linux,pci-domain property, which only makes sense when there are multiple host bridges. Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20200815125112.462652-3-maz@kernel.org Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 642fb27 commit 43f20b1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/arm64/boot/dts/rockchip/rk3399.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@
234234
reg = <0x0 0xf8000000 0x0 0x2000000>,
235235
<0x0 0xfd000000 0x0 0x1000000>;
236236
reg-names = "axi-base", "apb-base";
237+
device_type = "pci";
237238
#address-cells = <3>;
238239
#size-cells = <2>;
239240
#interrupt-cells = <1>;
@@ -252,7 +253,6 @@
252253
<0 0 0 2 &pcie0_intc 1>,
253254
<0 0 0 3 &pcie0_intc 2>,
254255
<0 0 0 4 &pcie0_intc 3>;
255-
linux,pci-domain = <0>;
256256
max-link-speed = <1>;
257257
msi-map = <0x0 &its 0x0 0x1000>;
258258
phys = <&pcie_phy 0>, <&pcie_phy 1>,

0 commit comments

Comments
 (0)